Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: implement app split tunneling support #435

Merged
merged 1 commit into from
Jul 3, 2024
Merged

android: implement app split tunneling support #435

merged 1 commit into from
Jul 3, 2024

Conversation

agottardo
Copy link
Collaborator

@agottardo agottardo commented Jun 26, 2024 •
edited
Loading

Updates tailscale/tailscale#6912

This PR is a little QoL improvement for our Android users. It adds UI and models that provide the ability to add/remove apps which should be excluded from going through the VPN tunnel.

To-dos

  • Test the interaction between this and the hardcoded list of excluded apps we already have
  • Implement logic to update the VPN settings while the app is running (currently, this PR requires you to disconnect and reconnect the tunnel to apply any exclusion choices).
  • Determine Play Store follow-up work as the QUERY_ALL_PACKAGES permission was needed to be added here

This was referenced Jun 27, 2024
Closed
Closed
@agottardo agottardo force-pushed the angott/app-split-tunneling branch 2 times, most recently from 11d3846 to d8f7303 Compare July 2, 2024 16:31
Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

Killdev33

This comment was marked as spam.

Sign in to view

@agottardo
android: implement app split tunneling support
c828572 
Updates tailscale/tailscale#6912

Adds UI and models that provide the ability to add/remove apps which should be excluded from going through the VPN tunnel.

Signed-off-by: Andrea Gottardo <[email protected]>
@agottardo agottardo merged commit 9b24888 into main Jul 3, 2024
4 checks passed
@agottardo agottardo deleted the angott/app-split-tunneling branch July 3, 2024 20:43
@agottardo agottardo mentioned this pull request Jul 4, 2024
Open
@mkevinstever
Copy link

Hello:
Split tunnel should be have ability to manage by admin. which means should controlled by tailnet admin allow client use it or disable it on tailnet.
At some agencies and organizations, they have stricter regulations on data control. simply called "don't allow data transfer leave company facilities"

@agottardo
Copy link
Collaborator Author

Split tunnel should be have ability to manage by admin.

That's being worked on. If you have concerns in the future about upcoming features, please open an actual issue as old pull requests are not monitored for new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Killdev33 Killdev33 Killdev33 requested changes

@barnstar barnstar barnstar approved these changes

@oxtoacart oxtoacart Awaiting requested review from oxtoacart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agottardo @mkevinstever @barnstar @Killdev33